Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated test methods with recommended alternatives #249

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

MarkEWaite
Copy link
Contributor

Replace deprecated test methods with recommended alternatives

The PresetData methods are replaced with a mock security realm that provides exactly the permissions desired.

Also adds one Override annotation that was missing.

Testing done

Confirmed that automated tests pass. Will check that coverage did not decrease on ci.jenkins.io.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The PresetData methods are replaced with a mock security realm that
provides exactly the permissions desired.

Also adds one Override annotation that was missing.
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Dec 10, 2024
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 10, 2024 02:04
@MarkEWaite MarkEWaite merged commit 2fff83e into jenkinsci:master Dec 10, 2024
18 checks passed
@MarkEWaite MarkEWaite deleted the reduce-compiler-warnings branch December 10, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant