Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dawidd6/action-send-mail action to v4 #9996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Update dawidd6/action-send-mail action to v4 #9996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/announce-lts-rc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
discourse-author-username: jenkins-release-bot
discourse-category: 23
- name: Post on mailing list
uses: dawidd6/action-send-mail@v3
uses: dawidd6/action-send-mail@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use hash instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-beck For what reason?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General good practice, see e.g. https://github.com/ossf/scorecard/blob/51f31c9882b6e5998e0df571096147a99842092b/docs/checks.md#pinned-dependencies for OpenSSF's take on this.

Previously done elsewhere in #7584.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that not a pre-existing issue? How is this PR introducing a problem?

with:
server_address: smtp.gmail.com
server_port: 465
Expand Down
Loading