Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#455 inadvertently packaged two new JARs into the JPI:
spring-core-6.1.14.jar
andfindbugs-annotations-3.0.1.jar
. FindBugs is a static analysis tool without runtime impact, and the Spring Core JAR isn't used at runtime from the plugin, anyway: it is provided by Jenkins core, which takes precedence (see here for details). Nor is shippingspring-core-6.1.14.jar
a problem today, as it is not vulnerable to any CVEs that might trip up scanners. But in the long term, it is a liability to ship a Spring library that we do not use that might trip scanners, so slim down the JPI so that it ships the same set of JARs (but with upgraded versions) as we shipped prior to #455.Testing done
Submitter checklist