Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75008] Replace outdated poll SCM icon with play symbol #48

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

MarkEWaite
Copy link
Contributor

[JENKINS-75008] Replace outdated poll SCM icon with play symbol

The play symbol is used by the "Scan repository" button for multibranch Pipelines and is used by the "Build Now" button for all jobs. Make the poll SCM plugin consistent with other usages by switching to the play icon.

JENKINS-75008 is the bug report

Testing done

Created a freestyle project that uses a git repository and enabled polling in the job definition so that the "Poll now" button was visible in the sidepanel. Confirmed that the button in the sidepanel was correct. Confirmed that clicking the button in the side panel performed a poll of the repository.

Ran the automated tests and confirmed that they pass with the changes.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The play symbol is used by the "Scan repository" button for multibranch
Pipelines and is used by the "Build Now" button for all jobs.  Make the
poll SCM plugin consistent with other usages by switching to the play
icon.

https://issues.jenkins.io/browse/JENKINS-75008 is the bug report

Testing done:

Created a freestyle project that uses a git repository and enabled
polling in the job definition so that the "Poll now" button was visible in
the sidepanel.  Confirmed that the button in the sidepanel was correct.
Confirmed that clicking the button in the side panel performed a poll
of the repository.

Ran the automated tests and confirmed that they pass with the changes.
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 27, 2024 17:09
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Dec 27, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation tests This PR adds/removes/updates test cases labels Dec 27, 2024
@MarkEWaite MarkEWaite merged commit 8eb4e88 into jenkinsci:master Dec 27, 2024
17 checks passed
@MarkEWaite MarkEWaite removed documentation Improvements or additions to documentation tests This PR adds/removes/updates test cases labels Dec 27, 2024
@MarkEWaite MarkEWaite deleted the replace-play-icon branch December 27, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant