-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email and display name header injection support - revised from PR #30 #124
Add email and display name header injection support - revised from PR #30 #124
Conversation
@sboardwell Hi could you have a look at this? |
Sorry, missed this somehow. Will check in the next few days. Thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've added a few nitpicks wrt code styling. Would you be able to add a test as well?
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
if(forwardedEmail!=null){ | ||
toReturn.setEmail(r.getHeader(forwardedEmail)); | ||
} | ||
if(forwardedDisplayName!=null){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(forwardedDisplayName!=null){ | |
if (forwardedDisplayName != null) { |
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/ReverseProxySecurityRealm.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Boardwell <[email protected]>
Thank you, I'll have a look what I can test. |
I added some basic tests |
I have added automated code formatting to the project to avoid having to think about it. This has caused some conflicts - apologies. Could you resolve them please, or would you like me to do it? |
It would be great if you could resolve the issue. |
This is a revised version from PR #30
Original text: