[JENKINS-74842] ClassCastException in ReverseProxySecurityRealm#loadGroupByGroupname2

[basil]

Sprinkling SetContextClassLoader in yet another place hoping that this fixes JENKINS-74842.

Testing done

None

[jglick]

Seems harmless, though I would expect any bug like this to be reproducible in tests, perhaps some extension to

reverse-proxy-auth-plugin/src/test/java/org/jenkinsci/plugins/reverse_proxy_auth/docker/PlanetExpressTest.java

Lines 103 to 104 in d99619b

	String leelaEmail = MailAddressResolver.resolve(j.jenkins.getUser("leela"));
	assertEquals("[email protected]", leelaEmail);

?

[basil]

Thanks, Jesse! Out of curiosity, why was this plugin not adapted to Spring Security as part of the Acegi removal project?

[jglick]

why was this plugin not adapted to Spring Security

A good question. At this point I do not really remember. It would have made sense to follow up #40 analogously to jenkinsci/ldap-plugin#49.

[basil]

Just as it would have made sense to write a test for this bug. 🤷‍♂️

[basil]

@sboardwell Could this please be released?

[sboardwell]

@basil I can do it this weekend. Travelling at the moment and the internet is not the best.

[jglick]

@sboardwell FYI if you set up https://www.jenkins.io/doc/developer/publishing/releasing-cd/ you can trigger a release from your phone (unless of course you need to do manual testing first).

[sboardwell]

I was going to do that as well at some point. How long does it take to set up approximately? I might do that and then release.

[jglick]

How long does it take to set up approximately?

Generally not long. If you like, I could file a PR for this repo which you could review & approve. I think I have physical permissions to merge here, probably for historical reasons.

[sboardwell]

That would be great if you have the time.

[jglick]

@sboardwell OK please review jenkins-infra/repository-permissions-updater#4177 + #154

[jglick]

Released as https://github.com/jenkinsci/reverse-proxy-auth-plugin/releases/tag/238.v82ceca_8417a_6