Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.479.1 or newer #326

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Oct 11, 2024

Require Jenkins 2.479.1 or newer

Compile with Java 17 and Jakarta EE 9

Transformation is incomplete because the plugin relies on an API provided by the JUnit plugin and that API is only available for the StaplerRequest / StaplerResponse signature and not for the StaplerRequest2 / StaplerResponse2 signature.

Testing done

Confirmed that automated tests pass.

Confirmed that the dependent plugin (Splunk) does not call any of the methods that changed their signatures

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite added the rfe Improvement or new feature label Oct 11, 2024
@github-actions github-actions bot added the dependencies Dependency related change label Oct 11, 2024
@MarkEWaite MarkEWaite force-pushed the require-jenkins-2.479 branch from 8d6064b to 4c816e2 Compare October 20, 2024 23:02
@MarkEWaite MarkEWaite force-pushed the require-jenkins-2.479 branch from 4c816e2 to 5a358c9 Compare October 28, 2024 01:11
@MarkEWaite MarkEWaite changed the title Require Jenkins 2.479 or newer Require Jenkins 2.479.1 or newer Oct 30, 2024
@MarkEWaite MarkEWaite removed the dependencies Dependency related change label Oct 30, 2024
@MarkEWaite MarkEWaite marked this pull request as ready for review October 30, 2024 21:10
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 30, 2024 21:10
@MarkEWaite MarkEWaite force-pushed the require-jenkins-2.479 branch from ba8dfa5 to 6310ca4 Compare November 1, 2024 15:07
@github-actions github-actions bot added the dependencies Dependency related change label Nov 1, 2024
@MarkEWaite MarkEWaite force-pushed the require-jenkins-2.479 branch from 6310ca4 to b02c1bd Compare November 9, 2024 04:05
@MarkEWaite MarkEWaite force-pushed the require-jenkins-2.479 branch 2 times, most recently from 3aa6931 to fc79c4a Compare November 22, 2024 16:23
@MarkEWaite MarkEWaite force-pushed the require-jenkins-2.479 branch from 29f1c89 to cf6006e Compare December 14, 2024 08:45
@github-actions github-actions bot added the skip-changelog Exclude from the changelog label Dec 14, 2024
@MarkEWaite MarkEWaite force-pushed the require-jenkins-2.479 branch 3 times, most recently from 69b8f94 to 7375916 Compare December 16, 2024 23:41
@MarkEWaite MarkEWaite removed dependencies Dependency related change skip-changelog Exclude from the changelog labels Dec 28, 2024
Compile with Java 17 and Jakarta EE 9

Transformation is incomplete because the plugin relies on an API
provided by the JUnit plugin and that API is only available for the
StaplerRequest / StaplerResponse signature and not for the StaplerRequest2
/ StaplerResponse2 signature.
@MarkEWaite MarkEWaite force-pushed the require-jenkins-2.479 branch from 81571ec to a85555f Compare January 1, 2025 18:51
@github-actions github-actions bot added the dependencies Dependency related change label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency related change rfe Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant