[JENKINS-70560] Improve DescriptorImpl test coverage

[code-arnab]

Testing done

Improved test coverage of DescriptorImpl by adding testMonitor_VersionIsNull_Ignored and modifying the existing testMonitor_VersionIsNull to testMonitor_VersionIsNull_NotIgnored. These changes cover both the cases where isIgnored is true and false respectively, and version is null.
Result - Test Coverage of DescriptorImpl improved from 86% to 100%. Overall plugin coverage improved from 81% to 83%.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

Thanks for the pull request. I think that you may be missing something in your development process. You need to checkout your local master branch and update it to the most recent master branch from this repository, then merge those changes into the monitor-test branch you're using for this pull request.

Some commands that you might consider to perform that operation locally, depending on your git configuration:

$ git checkout master
$ git pull --all --prune
$ git merge upstream/master
$ git push origin
$ git checkout monitor-test
$ git merge master

That last command (git merge master) will report a conflict that you will need to resolve.

[code-arnab]

Thanks for the pull request. I think that you may be missing something in your development process. You need to checkout your local master branch and update it to the most recent master branch from this repository, then merge those changes into the monitor-test branch you're using for this pull request.

Some commands that you might consider to perform that operation locally, depending on your git configuration:

$ git checkout master
$ git pull --all --prune
$ git merge upstream/master
$ git push origin
$ git checkout monitor-test
$ git merge master

That last command (git merge master) will report a conflict that you will need to resolve.

You're right! Let me update it locally.

[MarkEWaite]

It is a common mistake for new contributors that they forget to keep their local copy of the master branch current with the upstream copy of the master branch. That is a useful skill to develop.

[jonesbusy]

There are multiple option to achieve the same

For example using gh cli. I personnally prefer this to avoid configuring 2 remotes on your local git repository. But it's purely my choice

gh repo sync <user>/<repo> -b master
git fetch --all
git merge origin/master

[code-arnab]

There are multiple option to achieve the same

For example using gh cli. I personnally prefer this to avoid configuring 2 remotes on your local git repository. But it's purely my choice

gh repo sync <user>/<repo> -b master
git fetch --all
git merge origin/master

Thanks for the tip. I will try to learn more about this stuff.