Remove brittle tests, simplify VersionMonitorTest #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete two brittle tests. Jenkins 2.482 includes improvements that break the implementation assumptions embedded in the mocking used by the tests. Remove the tests rather than fight with the brittleness. Causes a minimal reduction in test coverage. Replace mocking in a few tests with objects provided by Jenkins core. Use actual remoting versions in the tests.
MarkEWaite
added
developer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove brittle tests, simplify VersionMonitorTest
Delete two brittle tests. Jenkins 2.482 includes improvements that break the implementation assumptions embedded in the mocking used by the tests. Remove the tests rather than fight with the brittleness. Causes a minimal reduction in test coverage.
Replace mocking in a few tests with objects provided by Jenkins core.
Use actual remoting versions in the tests.
Testing done
Confirmed that new tests pass with Jenkins 2.479.1 through Jenkins 2.493.
Submitter checklist