Changes to the final HTML document #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update all the function calls to work with the new arguments layout.
Without being to opinionated on taste it adds the following: - padding on code blocks (for better readability) - center and restrict "id=content" element to a comfortable read size - images are set to "width: 100%" to fit properly - "margin: 1em 0" on table elements to prevent the scroll bar from overlapping the table last row - small border radius on elements with background, like images and code blocks (this one is a bit opinionated, but I argue those sharp corner could be dangerous)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without being to opinionated on taste it adds the following:
overlapping the table last row
code blocks (this one is a bit opinionated, but I argue those sharp
corner could be dangerous)
Here's an image to see the differences: