Add -ObjC link flag to fix OSX crashes #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `-ObjC` link flag when building on OSX. As noted in SFML/SFML#2920, this is required when statically linking against SFML since it contains Objective-C source files. Without this flag, compiling and linking succeeds but binaries will crash at runtime.
|
Unfortunately, it seems that due to rust-lang/cargo#9554, this link flag isn't propagated to downstream users, but this change at least lets me run the examples within this crate. Until a workaround is found, perhaps we should document in the README or Wiki that downstream OSX users should add this to their build scripts? |
|
I have no way to test OS X personally, but CI passes, so looks good to me.
Feel free to edit the wiki, or submit a documentation pull request. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-ObjClink flag when building on OSX. As noted in SFML/SFML#2920, this is required when statically linking against SFML since it contains Objective-C source files. Without this flag, compiling and linking succeeds but binaries will crash at runtime.