using ProviderPlugin to add React/ReactDOM/jquery instead of adding s…

…tatic JS files in html
jerronl · Jul 28, 2017 · 8bfe36a · 8bfe36a
1 parent b208e89
commit 8bfe36a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/index.html b/src/index.html
@@ -2,9 +2,6 @@
 
 <html>
     <head>
-        <script src="https://fb.me/react-15.3.0.js"></script>
-        <script src="https://fb.me/react-dom-15.3.0.js"></script>
-        <script type="text/javascript" src="//cdnjs.cloudflare.com/ajax/libs/jquery/2.2.2/jquery.min.js"></script>
         <script type="text/javascript" src="https://golden-layout.com/files/latest/js/goldenlayout.min.js"></script>
         <link type="text/css" rel="stylesheet" href="https://golden-layout.com/files/latest/css/goldenlayout-base.css" />
         <link type="text/css" rel="stylesheet" href="https://golden-layout.com/assets/css/goldenlayout-dark-theme.css" />

diff --git a/webpack.config.babel.js b/webpack.config.babel.js
@@ -1,5 +1,6 @@
 import path from 'path';
 import HtmlWebpackPlugin from 'html-webpack-plugin';
+import webpack from 'webpack';
 
 export default () => ({
     entry: [
@@ -14,6 +15,13 @@ export default () => ({
         new HtmlWebpackPlugin({
            filename: 'index.html',
            template: './src/index.html'
+        }),
+        // Necessary b/c golden-layout depends on all 3 of these libs via UMD globals
+        new webpack.ProvidePlugin({
+            React: 'react',
+            ReactDOM: 'react-dom',
+            $: 'jquery',
+            jQuery: 'jquery'
         })
     ],
     module: {