-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propulsion.Tool: Add support for Cosmos Autoscaling #142
Propulsion.Tool: Add support for Cosmos Autoscaling #142
Conversation
…caling throughput of Cosmos containers and databases. Specifying this flag causes the --rus parameter to be interpreted as "Maximum RU/s" and changes the default value to 4000 RU/s (the minimum MaxRUs value allowed by Cosmos). The hardcoding which existed in 'Equinox.CosmosStore.Core.Initialization.initAux' to enforce a default behavior of 'Manual throughput with 400 RU/s' has been brought into the propulsion tool.
Did some cleanup on the stuff I cited as being good to copy, sorry 😊 ! |
…collection initialization in autoscale mode. Propulsion tool change recorded in CHANGELOG.md.
Thanks for review. I have pushed fixes pertaining to all the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Let me know when you're happy and I'll get it into the outbox
I have tested the changes a few times and its working. We can proceed with the merge. |
Thanks for your contribution! Will ping when it hits nuget (will be |
(It's on nuget now https://www.nuget.org/packages/Propulsion.Tool/2.13.0-beta.7) |
Thank you for helping with the change :). Designing CLI tool is an art and your churn is a proof :). |
Adds an --autoscale/-A switch to the propulsion tool to support autoscaling throughput of Cosmos containers and databases. Specifying this flag causes the --rus parameter to be interpreted as "Maximum RU/s" and changes the default value to 4000 RU/s (the minimum MaxRUs value allowed by Cosmos).
The hardcoding which existed in 'Equinox.CosmosStore.Core.Initialization.initAux' to enforce a default behavior of 'Manual throughput with 400 RU/s' has been brought into the propulsion tool.