Threaded threads #78

cyisfor · 2020-06-01T03:59:14Z

Making threads look like a tree, so you can see who's replying to what.

(#fff) is not a good background color to compose posts in, that are then displayed with the dark background color.

Pleroma will send records that cause brutaldon to make pleroma-specific responses, which the mastodon python module wigs out on claiming it doesn't support that "feature set" so allow for a feature set to be specified...

Recreate the mastodon object if there's an error complaining about a missing feature set. Only happens for status_post I think. Could be further generalized...

No need to list the preference fields three times in three places in the code. A class decorator ought to be able to sleuth them out from the model itself. Should make it easier to add new preferences.

Because when you add one field to a class, you clearly want to add two fields to a class, and there's no need to consider the field you never asked to add to be something other than a field.

A setting to not censor sensitive images if you think you're not in danger for looking at them.

Add a preference to open details by default.

I couldn't tell who was replying to whom, so I thought I'd give a shot at implementing a tree of threads, instead of a flattened list, with only the root distinguishable from the rest.

Doing some token based temporary flattening for django

It was saying stuff was unhashable, but I thought I was just hashing by post ID.

Python's dynamic typing doesn't make this easy...

I think I got it working.

If we have multiple roots ever, we need the whole thing in a big <ul></ul>

Is nothing in reply to the root post? Nothing at all?

More debugging...

Trying to find why only the one post comes out with no replies

I can't imagine how, but...#

Trying to find how to thread stuff is harder than I thought it would be. Where's the root?

The top level roots acts like any other level, I noticed.

Trying to add the leftover toots that don't reply to anything at the end.

1) initialize seen to empty 2) get all posts not in seen 3) add posts to seen because the generator was iterated over lazily 4) wonder why it looks like there weren't any posts in seen yeah... leftovers has to be lazy too.

We have the post ID, so why would Pleroma not send us the post? Request any missing posts it hasn't sent us, to try and get a thread that doesn't lose all its replies.

Right, I forgot I was in the middle of changing the name post to toot. Thus explaining why op.post had an empty result, since op.toot was what I changed.

Oh for Pete's sake I'm an idiot. The descendants array isn't going to contain the root post at all, because it's totally separate. That's the missing post everything was trying to reply to!

I thought the root post only displayed once. Maybe it needs to be removed?

Right, the template is where the duplication of the root is, since now the root is just the first "descendant" in the tree.

Now that everything is a <li> can set the margin-top value to make a gap, instead of making a visible "invisible" hr. And with the template thread.html fixed, it seems to be working, showing everything as a tree, instead of a flat list.

There's a merge conflict if I try to separate out this branch...

I guess it might be useful for mobile users?

Gah, I forgot brutaldon had client side filters

The code was looking up toots, then throwing them away because I'm an idiot.

I guess I have to copypaste this into the light theme too...

jfmcbrayer · 2020-07-08T17:42:53Z

I've been playing with this on a branch. I absolutely love the idea, and the implementation is pretty close. It breaks down on mobile, though – the screen becomes wider than the viewport. Do you have the CSS skills to fix it up?

Cy and others added 30 commits May 30, 2020 21:23

textareas and inputs in bulmaswatch-darkly were hurting my eyes.

bf0394c

(#fff) is not a good background color to compose posts in, that are then displayed with the dark background color.

Support feature_set= other than mainline for Mastodon

2dfdb0b

Pleroma will send records that cause brutaldon to make pleroma-specific responses, which the mastodon python module wigs out on claiming it doesn't support that "feature set" so allow for a feature set to be specified...

Handle feature_set errors automatically

12d7b4c

Recreate the mastodon object if there's an error complaining about a missing feature set. Only happens for status_post I think. Could be further generalized...

Refactoring preferences to be more cohesive

0b93eb7

No need to list the preference fields three times in three places in the code. A class decorator ought to be able to sleuth them out from the model itself. Should make it easier to add new preferences.

Foreign keys add magic members

0439440

Because when you add one field to a class, you clearly want to add two fields to a class, and there's no need to consider the field you never asked to add to be something other than a field.

Allow previewing sensitive images

39f13d6

A setting to not censor sensitive images if you think you're not in danger for looking at them.

Add open_details preference

543a83c

Add a preference to open details by default.

Missed a few status_post calls

c0caab4

whoops, left an old mistake in the code

9415def

Viewing threads as a tree, not flattened

7b86cf7

I couldn't tell who was replying to whom, so I thought I'd give a shot at implementing a tree of threads, instead of a flattened list, with only the root distinguishable from the rest.

Cleaning up, adding tokens

4e94878

Doing some token based temporary flattening for django

Debugging a lookup error

4faba56

It was saying stuff was unhashable, but I thought I was just hashing by post ID.

Still trying to figure out what my data structure is

82b2c9f

Python's dynamic typing doesn't make this easy...

OK no hashable errors anymore

2c8cdac

I think I got it working.

Adding an outer IN/OUT

2308d65

If we have multiple roots ever, we need the whole thing in a big <ul></ul>

Trying to figure out why only the root post is coming through

933961b

Is nothing in reply to the root post? Nothing at all?

Nothing at all?

631c140

More debugging...

Monitor tree building progress

7552f4e

Trying to find why only the one post comes out with no replies

Still trying...

cc826ff

Maybe the root is getting filtered out?

e887978

I can't imagine how, but...#

Yet more debugging

09c5a4f

Trying to find how to thread stuff is harder than I thought it would be. Where's the root?

Sorting to make it easier to read when debugging

43cb98a

Removing redundant code

e8b5cf6

The top level roots acts like any other level, I noticed.

Leftovers?

05605bf

Trying to add the leftover toots that don't reply to anything at the end.

Leftovers isn't lazy enough

e76c758

1) initialize seen to empty 2) get all posts not in seen 3) add posts to seen because the generator was iterated over lazily 4) wonder why it looks like there weren't any posts in seen yeah... leftovers has to be lazy too.

auto 0 20 244

3d96963

Pulling any missing posts by ID

8cda922

We have the post ID, so why would Pleroma not send us the post? Request any missing posts it hasn't sent us, to try and get a thread that doesn't lose all its replies.

Consistent naming

5187715

Right, I forgot I was in the middle of changing the name post to toot. Thus explaining why op.post had an empty result, since op.toot was what I changed.

The root post is not included in its descendants

2cf2e77

Oh for Pete's sake I'm an idiot. The descendants array isn't going to contain the root post at all, because it's totally separate. That's the missing post everything was trying to reply to!

Why is the root post displaying twice?

f900be0

I thought the root post only displayed once. Maybe it needs to be removed?

Cy and others added 2 commits June 1, 2020 03:46

The template prints out the root by itself

b306f38

Right, the template is where the duplication of the root is, since now the root is just the first "descendant" in the tree.

Changing the template, prettifying a bit

a0433a1

Now that everything is a <li> can set the margin-top value to make a gap, instead of making a visible "invisible" hr. And with the template thread.html fixed, it seems to be working, showing everything as a tree, instead of a flat list.

cyisfor force-pushed the threaded_threads branch from a6346a4 to a0433a1 Compare June 1, 2020 08:35

Cy and others added 10 commits June 1, 2020 18:28

Merge branch 'preview_sensitive' into threaded_threads

50f05d7

Merge branch 'open_details_preference' into HEAD

d682f62

Merge branch 'dark_textareas' into threaded_threads

aee3b13

There's a merge conflict if I try to separate out this branch...

Preference setting for whether to make threads a tree or not

77e352b

I guess it might be useful for mobile users?

Tree thread preference seems to be working.

70e0eea

This is needed to make settings waste more sp--I mean prettier

f2f8e7a

Re-enable filtering

72c6ba5

Gah, I forgot brutaldon had client side filters

Actually return the toots being looked up

36fc686

The code was looking up toots, then throwing them away because I'm an idiot.

Allowing for horizontal scrolling for deeply nested threads.

e2cf103

I guess I have to copypaste this into the light theme too...

Removing some debugging output I missed

2fc42ad

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Threaded threads #78

Threaded threads #78

cyisfor commented Jun 1, 2020

jfmcbrayer commented Jul 8, 2020

Threaded threads #78

Are you sure you want to change the base?

Threaded threads #78

Conversation

cyisfor commented Jun 1, 2020

jfmcbrayer commented Jul 8, 2020