Mri 19 compat #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Down from 14 test failures to 5. Notable fixes: * Class#instance_methods is now an Array of Symbol, not of String * Indexing into a String now produces a String, not an Integer * When a method is defined using define_method and a block, we now can't call the method with an argument if the block has arity zero
Calling `respond_to_superator?` before invoking the superator is costly. Instead, just invoke the superator and catch a NoMethodError if one is raised. This improves the performance of a microbenchmark (superator invocation x 10000) from ~2 seconds to ~1.3 seconds.
We previously detected the arity of the superator block by passing it into superator_send(); we now lookup the corresponding Method via Object#method() and use Method#arity. This is very slightly slower, but avoids changing the API.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to allow superators to work with MRI 1.9. Also optimized superator dispatch somewhat.