-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a WKWebView based example #10
Conversation
…iption to the readme. Added some pitfalls I’ve faced to the readme too.
It turned out that WKWebview does not need this POD or NSUrlProtocol hooks.
The "foo/bar" example with basic authorization works fine in WKWebView. I'll push more commits when I discover the correct settings for |
Using an isolated non-persistent site data store pops up the alert for NTLM but that does not help the playback yet. WKWebViewConfiguration* config = [WKWebViewConfiguration new];
config.allowsInlineMediaPlayback = YES;
config.allowsPictureInPictureMediaPlayback = NO;
config.mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAll;
config.websiteDataStore = [WKWebsiteDataStore nonPersistentDataStore]; |
Never mind, the video's URL scheme was Alternatively, JavaScript injection could be used if the server can serve videos via The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor request.
[self.webView loadRequest: request]; | ||
} | ||
|
||
#pragma mark - JAHPAuthenticatingHTTPProtocolDelegate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should bring JAHPAuthenticatingHTTPProtocolDelegate
into this at all. It isn't needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted the mentioned #pragma mark
Will be merged as part of a more recent PR #11 |
WKWebView does not need this POD to achieve the same thing.
Still, I think the example and a readme mention might be useful.
Based on #9
After merging that one, the diffs should become more brief.