Switched to a TQDM bar that adapts for both chat & notebooks #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed at #335 (comment), I think a migration to https://pypi.org/project/rich-cli would offer many more possibilities for future expansion. |
|
Yes, but that would not address the user experience when using Jupyter Notebooks, which is why I made this pull request. |
cclauss
added a commit
to cclauss/internetarchive
that referenced
this pull request
Dec 6, 2022
cclauss
approved these changes
Dec 8, 2022
|
Failing tests should be fixed by #571 |
|
Please rebase to ensure that all tests pass. |
|
Hi @cclauss, I haven't understood whether I should be doing anything. I am not familiar with the CI suite of this library. |
|
I fixed the CI in #571 which has now been merged into the current |
|
Is this correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.