Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement password authentication #44

Merged
merged 2 commits into from
Feb 4, 2025
Merged

feat: implement password authentication #44

merged 2 commits into from
Feb 4, 2025

Conversation

shtw
Copy link
Contributor

@shtw shtw commented Feb 4, 2025

Hello @jkuri thank you for creating this awesome tool!

I have added an authentication feature for both the server and client, based on feature request #42
The authentication method works similarly to set-id, where the client must provide a password to connect to the server.

Usage

Server

BORE_PASSWORD=mysecretpassword BORE_DOMAIN=example.com BORE_HTTPADDR=0.0.0.0:80 BORE_SSHADDR=0.0.0.0:2200 ./build/bore-server

Client

./build/bore -s example.com -p 2200 -ls localhost -lp 6500 -pw mysecretpassword

Please review the changes, and let me know if there's anything that needs improvement.
Looking forward to your feedback. Thanks!

@jkuri
Copy link
Owner

jkuri commented Feb 4, 2025

Hi @shtw, thank you for this PR! I did not tested it in action but everything looks legit. Can you please add this to the README documentation so other users will know how to use it?

@shtw
Copy link
Contributor Author

shtw commented Feb 4, 2025

Hi @shtw, thank you for this PR! I did not tested it in action but everything looks legit. Can you please add this to the README documentation so other users will know how to use it?

I've updated the README to include the authentication feature.

@jkuri jkuri merged commit 4db6c88 into jkuri:master Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants