Added new Form Field: "Interkey Delay (ms)" #7
Conversation
|
Hey @dernate, thanks for this! I've left a couple comments on the PR, but in principle this looks like a good feature to have. |
|
Hey @jlaundry, where can I find your comments? This is one of the first FOSS PR I tried. |
|
@dernate scroll up in this Conversation tab, or inline with the code on the Files Changed tab 😊 |
|
Unfortunately I cannot see any of your comments - wether in the conversations nor in the files changed tab... Sorry. I assume it should look like shown here but I cannot see it. Did you "finished" your review? |
| @@ -27,14 +33,19 @@ protected override CreateParams CreateParams | |||
| get | |||
| { | |||
| CreateParams param = base.CreateParams; | |||
| param.ExStyle |= WS_EX_NOACTIVATE; | |||
| param.ExStyle |= WS_EX_TOPMOST; | |||
There was a problem hiding this comment.
I think I understand the UI benefit to WS_EX_TOPMOST and ShowWithoutActivation, but is there a particular burning reason for the change?
(I suspect there may be issues with non-MS RDP apps which do funny things with low-level keyboard handlers, like Horizon View)
| @@ -92,7 +93,8 @@ private IntPtr HookCallback(int nCode, IntPtr wParam, IntPtr lParam) | |||
| if (keyPressed == Key.F8) | |||
| { | |||
| // Call Type Clipboard | |||
| _tc.TypeClipboard(100); | |||
| // ToDo: Implement get values of interkeyDelay and delay from the form | |||
| _tc.TypeClipboard(20, 100); | |||
There was a problem hiding this comment.
Given the screenshot below, looks like this was an earlier commit?
There was a problem hiding this comment.
Looks like this is missing the added tbInterkeyDelay control, size changes, etc. - possibly an earlier commit?
Hi,
I added a new Form Field "Interkey Delay (ms)" to change the default 20ms via UI. It helps inputting the correct keys, if the computer or connection is too slow. For example if you have a rdp session inside a rdp session and you want to use TypeClipboard, sometimes the shift key is not properly set, because the connection is laggy. When I changed the Interkey Delay to a higher value (like 100ms) the keys were inputted correctly.
I hope this change meets your standards.