[BUGFIX] Create persist log directory if it does not exist (#513)

jmbannon · Mar 8, 2023 · fd1934b · fd1934b
1 parent 6480272
commit fd1934b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/ytdl_sub/cli/main.py b/src/ytdl_sub/cli/main.py
@@ -1,4 +1,5 @@
 import gc
+import os
 import sys
 from datetime import datetime
 from pathlib import Path
@@ -54,6 +55,7 @@ def _maybe_write_subscription_log_file(
     if not success:
         Logger.log_exit_exception(exception=exception, log_filepath=persist_log_path)
 
+    os.makedirs(os.path.dirname(persist_log_path), exist_ok=True)
     FileHandler.copy(Logger.debug_log_filename(), persist_log_path)
 
 

diff --git a/tests/unit/cli/test_main.py b/tests/unit/cli/test_main.py
@@ -1,4 +1,6 @@
+import os.path
 import re
+import shutil
 import tempfile
 import time
 from pathlib import Path
@@ -16,9 +18,15 @@
 
 
 @pytest.fixture
-def persist_logs_directory():
+def persist_logs_directory() -> str:
+    # Delete the temp_dir on creation
     with tempfile.TemporaryDirectory() as temp_dir:
-        yield temp_dir
+        pass
+
+    yield temp_dir
+
+    if os.path.isdir(temp_dir):
+        shutil.rmtree(temp_dir)
 
 
 @pytest.fixture