Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for cron path #1100

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

dsgnr
Copy link
Contributor

@dsgnr dsgnr commented Oct 25, 2024

Fixes cron paths in documentation.

Spotted these when configuring. Then noticed #1073 was already open.

Resolves #1073

@@ -81,7 +81,7 @@ Docker and Unraid

docker compose restart

The script that will execute automatically is located at ``/config/run-cron``.
The script that will execute automatically is located at ``/config/ytdl-sub-configs/run_cron``.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/config/run_cron is the path for headless -- doesn't have the ytdl-sub-configs folder

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the .. tab-item part which separates GUI from headless

@@ -105,14 +105,14 @@ Docker and Unraid

.. code-block::

/config/run_cron
/config/ytdl-sub-configs/run_cron
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's actually right above this part that needs to not use ytdl-sub-configs 🙂

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (7676fd9) to head (e8e4c0a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1100   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files         113      113           
  Lines        7430     7430           
=======================================
  Hits         6794     6794           
  Misses        636      636           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbannon jmbannon merged commit 102e2a9 into jmbannon:master Oct 27, 2024
32 checks passed
@jmbannon
Copy link
Owner

Much appreciated @dsgnr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cron script docs
2 participants