-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Gha docker metadata actions to setup all the github actions #1116
Conversation
To be on the safer side, let's do this test on the headless ubuntu image before the main headless image: https://github.com/jmbannon/ytdl-sub/blob/master/.github/workflows/package-ubuntu.yaml We will need to update that and the GUI image as well, should mostly be copy paste. |
I'm going to test it on my fork, it seems less of a concern Also gonna leave https://github.com/docker/metadata-action?tab=readme-ov-file#typesemver here, as it could also improve the bash to generate tag names, but i don't want to do multiple things in one pr |
103be9b
to
b690cf0
Compare
closeeeeeeeeee |
I'm done for tonight, time change is messing with me. But do you want me to do another pipeline instead/in addition/seperate pr? Or just remove the code that supports the test branch? |
Looks great @halkeye ! Let's remove the workflow test branch in this PR. Ideally I'd like to update the other workflows in the same PR, but I'll leave it to you if you're up for the task. I can do a follow-up otherwise |
3f4be2f
to
71eb39a
Compare
There might be a few more labels you want to tweak, but i think its good enough for this pr |
and i think i removed the commit with the test branch |
Use docker/metadata-action to build labels to fix #1115