Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gha docker metadata actions to setup all the github actions #1116

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Nov 4, 2024

Use docker/metadata-action to build labels to fix #1115

@jmbannon
Copy link
Owner

jmbannon commented Nov 4, 2024

To be on the safer side, let's do this test on the headless ubuntu image before the main headless image: https://github.com/jmbannon/ytdl-sub/blob/master/.github/workflows/package-ubuntu.yaml

We will need to update that and the GUI image as well, should mostly be copy paste.
https://github.com/jmbannon/ytdl-sub/blob/master/.github/workflows/package-gui.yaml

@halkeye
Copy link
Contributor Author

halkeye commented Nov 4, 2024

I'm going to test it on my fork, it seems less of a concern

Also gonna leave https://github.com/docker/metadata-action?tab=readme-ov-file#typesemver here, as it could also improve the bash to generate tag names, but i don't want to do multiple things in one pr

@halkeye halkeye force-pushed the gha-1115 branch 2 times, most recently from 103be9b to b690cf0 Compare November 4, 2024 05:34
@halkeye
Copy link
Contributor Author

halkeye commented Nov 4, 2024

regctl image config --format '{{ jsonPretty .Config.Labels }}' ghcr.io/halkeye/ytdl-sub:2024.11.04
{
  "build_version": "Linuxserver.io version:- bbef08a9-ls161 Build-date:- 2024-09-28T13:37:29+00:00",
  "maintainer": "TheLamer",
  "org.opencontainers.image.authors": "linuxserver.io",
  "org.opencontainers.image.created": "2024-11-04T05:41:02.122Z",
  "org.opencontainers.image.description": "Lightweight tool to automate downloading and metadata generation with yt-dlp",
  "org.opencontainers.image.documentation": "https://docs.linuxserver.io/images/docker-baseimage-alpine",
  "org.opencontainers.image.licenses": "GPL-3.0",
  "org.opencontainers.image.ref.name": "4356a5ee099f5286605bebc1b379b99c35cf4c75",
  "org.opencontainers.image.revision": "b690cf0dae35b985b41e0e19577a0e920f4f5cbd",
  "org.opencontainers.image.source": "https://github.com/halkeye/ytdl-sub",
  "org.opencontainers.image.title": "ytdl-sub",
  "org.opencontainers.image.url": "https://github.com/halkeye/ytdl-sub",
  "org.opencontainers.image.vendor": "linuxserver.io",
  "org.opencontainers.image.version": "latest",
  "runnumber": "${GITHUB_RUN_ID}"
}

closeeeeeeeeee

@halkeye
Copy link
Contributor Author

halkeye commented Nov 4, 2024

 regctl image config --format '{{ jsonPretty .Config.Labels }}' ghcr.io/halkeye/ytdl-sub:2024.11.04
{
  "build_version": "Linuxserver.io version:- bbef08a9-ls161 Build-date:- 2024-09-28T13:37:29+00:00",
  "maintainer": "halkeye",
  "org.opencontainers.image.authors": "halkeye",
  "org.opencontainers.image.created": "2024-11-04T06:11:02.780Z",
  "org.opencontainers.image.description": "Lightweight tool to automate downloading and metadata generation with yt-dlp",
  "org.opencontainers.image.documentation": "https://ytdl-sub.readthedocs.io/",
  "org.opencontainers.image.licenses": "GPL-3.0",
  "org.opencontainers.image.ref.name": "4356a5ee099f5286605bebc1b379b99c35cf4c75",
  "org.opencontainers.image.revision": "d66115113fbc26df3633e31392196d940bba1575",
  "org.opencontainers.image.source": "https://github.com/halkeye/ytdl-sub",
  "org.opencontainers.image.title": "ytdl-sub",
  "org.opencontainers.image.url": "https://github.com/halkeye/ytdl-sub",
  "org.opencontainers.image.vendor": "halkeye",
  "org.opencontainers.image.version": "latest",
  "runnumber": "7"
}

I'm done for tonight, time change is messing with me. But do you want me to do another pipeline instead/in addition/seperate pr? Or just remove the code that supports the test branch?

@jmbannon
Copy link
Owner

jmbannon commented Nov 5, 2024

Looks great @halkeye ! Let's remove the workflow test branch in this PR. Ideally I'd like to update the other workflows in the same PR, but I'll leave it to you if you're up for the task. I can do a follow-up otherwise

@halkeye halkeye force-pushed the gha-1115 branch 3 times, most recently from 3f4be2f to 71eb39a Compare November 6, 2024 07:31
@halkeye
Copy link
Contributor Author

halkeye commented Nov 6, 2024

regctl image config --format '{{ jsonPretty .Config.Labels }}' ghcr.io/halkeye/ytdl-sub:ubuntu-2024.11.06
{
  "build_version": "Linuxserver.io version:- 102276d2-ls121 Build-date:- 2024-10-01T23:36:52+00:00",
  "maintainer": "halkeye",
  "org.opencontainers.image.authors": "halkeye",
  "org.opencontainers.image.created": "2024-11-06T07:37:47.192Z",
  "org.opencontainers.image.description": "Lightweight tool to automate downloading and metadata generation with yt-dlp",
  "org.opencontainers.image.documentation": "https://ytdl-sub.readthedocs.io/",
  "org.opencontainers.image.licenses": "GPL-3.0",
  "org.opencontainers.image.ref.name": "93b4c6be0e8e1611d1611586695cecec45992df6",
  "org.opencontainers.image.revision": "71eb39abefe8e20be17d54da8ff41742ed98cd77",
  "org.opencontainers.image.source": "https://github.com/halkeye/ytdl-sub",
  "org.opencontainers.image.title": "ytdl-sub",
  "org.opencontainers.image.url": "https://github.com/halkeye/ytdl-sub",
  "org.opencontainers.image.vendor": "halkeye",
  "org.opencontainers.image.version": "ubuntu-latest",
  "runnumber": "3"
}
regctl image config --format '{{ jsonPretty .Config.Labels }}' ghcr.io/halkeye/ytdl-sub-gui
{
  "build_version": "Linuxserver.io version:- 4.18.0-ls181 Build-date:- 2023-11-03T20:27:55+00:00",
  "maintainer": "halkeye",
  "org.opencontainers.image.authors": "halkeye",
  "org.opencontainers.image.created": "2024-11-06T07:42:35.813Z",
  "org.opencontainers.image.description": "Lightweight tool to automate downloading and metadata generation with yt-dlp",
  "org.opencontainers.image.documentation": "https://ytdl-sub.readthedocs.io/",
  "org.opencontainers.image.licenses": "GPL-3.0",
  "org.opencontainers.image.ref.name": "02a7bea1b8f8f4f97ed95799deea0de34a4064fa",
  "org.opencontainers.image.revision": "71eb39abefe8e20be17d54da8ff41742ed98cd77",
  "org.opencontainers.image.source": "https://github.com/halkeye/ytdl-sub",
  "org.opencontainers.image.title": "ytdl-sub",
  "org.opencontainers.image.url": "https://github.com/halkeye/ytdl-sub",
  "org.opencontainers.image.vendor": "halkeye",
  "org.opencontainers.image.version": "latest",
  "runnumber": "3"
}

There might be a few more labels you want to tweak, but i think its good enough for this pr

@halkeye
Copy link
Contributor Author

halkeye commented Nov 6, 2024

and i think i removed the commit with the test branch

@jmbannon jmbannon merged commit 0f542ac into jmbannon:master Nov 6, 2024
32 checks passed
@halkeye
Copy link
Contributor Author

halkeye commented Nov 8, 2024

image
IT WORKEEEDDDDDDDDDDDDDD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker labels are pointing to linuxserver not this repo
2 participants