include pyyaml-include as a dependency #761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No WebM, Best quality, No AV1 either
Forcing Plex to download only MP4 and 1080P. More efficient then downloading Webm and converting. Plex does not direct Play AV1 currently anyway.
Default will get best video in H265 or H264, if neither are available, it will get next best video. All MP4, no limit on resolution. Plex_tv_show_av1 will allow for absolute best possible resolution in any codec as long as its MP4, including Av1 which is not currently supported in Plex. Without AV1 is considered default, for maximum compatibility at this time.
max_1080_video_quality:
Removed remux video Shortened preset name.
Update presets.rst documentation to reflect the "max_1080P" preset
Add pyyaml-include as a required dependency
|
I'm open to including it if it works with no issues - which can be done in a unit test. My hunch is it won't play nice with how ytdl-sub loads/validates yamls |
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 96.83% 96.77% -0.07%
==========================================
Files 70 70
Lines 4893 4893
==========================================
- Hits 4738 4735 -3
- Misses 155 158 +3 |
|
Going to close for now because I just came close to accidentally merging it lol. But am still open to a pyyaml-include PR so long as it has functionality included - no point in adding an extra dep with no use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you in advancing for approving my PR. :)
This will include (pun intended) pyyaml-include.
Will help advance clean single file subscription and config files