This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Simplify HTTPS listening, leverage net/http methods #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of net/http Server.ListenAndServeTLS — this gives upcoming http2 support in Go 1.6 for free.
|
@artyom Should basically the same change be made to ServeHTTP? |
|
@joejulian yes, similar changes can be applied to http listening endpoint; ServeHTTP method does the same "setup listener and run accept loop" logic. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of net/http Server.ListenAndServeTLS — this gives upcoming
http2 support in Go 1.6 for free.
bitly#167