Skip to content

Commit

Permalink
ci: Update release workflow
Browse files Browse the repository at this point in the history
Replaces a third-party action with the official GitHub command line, to avoid exposing priveleged tokens to a third-party
  • Loading branch information
joeyparrish committed Dec 19, 2024
1 parent 97f6292 commit a5fd9e7
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions .github/workflows/release-please.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,10 @@ jobs:
python3 -m twine check --strict dist/*
- name: Attach modules to the release
uses: svenstaro/upload-release-action@84f3aed82331a2c0c665cf8e9707228f766aba9d
with:
repo_token: ${{ secrets.RELEASE_PLEASE_TOKEN }}
tag: ${{ needs.release.outputs.tag_name }}
file: dist/*
file_glob: true
overwrite: true
env:
GH_TOKEN: ${{ secrets.RELEASE_PLEASE_TOKEN }}
run: |
gh release upload --clobber "${{ needs.release.outputs.tag_name }}" dist/*
# This uses PyPi's trusted publishing config. It can see and verify that
# the publication request comes from this repo and this exact workflow,
Expand Down

0 comments on commit a5fd9e7

Please sign in to comment.