feat: update notes #102
johnnyonlineAnnotations
14 warnings
|
commits
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
solidity
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
solidity
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v1, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
solidity:
src/periphery/SiloUsdcLenderAprOracle.sol#L2
Found more than One contract per file. 2 contracts found!
|
|
solidity:
src/periphery/SiloUsdcLenderAprOracle.sol#L38
Use Custom Errors instead of revert statements
|
|
solidity:
src/periphery/SiloUsdcLenderAprOracle.sol#L54
Use Custom Errors instead of require statements
|
|
solidity:
src/periphery/SiloUsdcLenderAprOracle.sol#L57
Use Custom Errors instead of require statements
|
|
solidity:
src/periphery/SiloUsdcLenderAprOracle.sol#L112
Use Custom Errors instead of revert statements
|
|
solidity:
src/staking/StakingRewardsMulti.sol#L94
Constant name must be in capitalized SNAKE_CASE
|
|
solidity:
src/staking/StakingRewardsMulti.sol#L118
Provide an error message for revert
|
|
solidity:
src/staking/StakingRewardsMulti.sol#L118
Use Custom Errors instead of revert statements
|
|
solidity:
src/staking/StakingRewardsMulti.sol#L123
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
solidity:
src/staking/StakingRewardsMulti.sol#L170
Provide an error message for revert
|
|
solidity
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|