Refactoring - improving coverage #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* More testing of ReadConfig() and its fallback mechanism * Found that if someone put a '"' double quote into the filename that we configure zap to log to, it would cause the the JSON created to be invalid. I have replaced the JSON string with proper config
…valid value instead of silently failing. added a basic test for api.setupTLS() (to increase test coverage)
Open
Bumping github-actions workflow versions to accommodate some changes in upstream golanci-lint
|
not sure why the lint is erroring on my use of the |
|
Yeah, it's a bit messy. Currently sitting in a train, trying to debug and figure it out. The overall plan is to migrate acme-dns to "acme-dns" organization after this refactoring is done. I think I'll just take your branch, bump dependencies and push it there. |
|
For the golangci-lint error about the output format the solution was to bump the version of the github action, as the previous one was old. But yeah, the rand one is weird for sure. |
|
locally I am running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started writing some unit tests to improve coverage of the refactoring.
This PR should bring coverage of the
acmednspackage up to 100%