WIP: remove dependency on sh for integration tests #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly involves fixing the hook tests.
Not succesful yet, can't get the stdin to work :/
|
I'm a bit stuck on this PR, having spent multiple hours on this without finding the solution. Long story short, I can't get the input prompt answering to work via stdin. I've merged a more independent part of this work in #397 and will let this PR rest for a bit. I believe the next steps here now are to write a very simple test program that prompts the user for some input and then see if I can get this subprocess code (or a simplified version of it) to work against that simple test program. |
jorisroovers
force-pushed
the
main
branch
2 times, most recently
from
4e25c66 to
f5ef2ee
Compare
jorisroovers
force-pushed
the
main
branch
7 times, most recently
from
ee64803 to
2b95f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly involves fixing the hook tests.