Do not blindly lowercase language names #37
Conversation
Rather than that, only do that if they are completely uppercased (which is probably the cause of a \MakeUppercase e.g. in headings) This assures miced-case names such as USenglish are treated correctly Fixes issue #12.
This has been addressed. |
|
Looks broadly good, though I'd like some groups/private vars. Longer-term, with the |
|
All comments have been addressed. |
| \begingroup | ||
| \def\csq@tempa{#1}% | ||
| \def\csq@tempb{\MakeUppercase{#1}}% | ||
| \ifx\csq@tempa\csq@tempb |
There was a problem hiding this comment.
isn't this test always false, given the two non equal definitions above?
There was a problem hiding this comment.
You're right. I forgot \MakeUppercase is not expandable.
@josephwright please revert my commit.
There was a problem hiding this comment.
ifx would be false even if it were expandable (but you could have fixed it with edef in that case)
There was a problem hiding this comment.
assuming that the names are always ascii (so the later \lowercase is safe) you could do \uppercase{\def\csq@tempb{#1}} then \ifx\csq@tempa\csq@tempb
There was a problem hiding this comment.
Yes, this seems to work.
diff --git a/csquotes.sty b/csquotes.sty
index dacb622..50a5401 100644
--- a/csquotes.sty
+++ b/csquotes.sty
@@ -832,7 +832,7 @@
\def\csq@lc@if@uc#1{%
\begingroup
\def\csq@tempa{#1}%
- \def\csq@tempb{\MakeUppercase{#1}}%
+ \uppercase{\def\csq@tempb{#1}}%
\ifx\csq@tempa\csq@tempb
\lowercase{#1}%
\else@josephwright, interested?
Rather than that, only do that if they are completely uppercased
(which is probably the cause of a
\MakeUppercasee.g. in headings)This assures mixed-case names such as
USenglishare treated correctlyFixes issue #12.
This revokes #13 which was screwed.
I've addressed #13 (comment)
If you dislike the approach in general, feel free to close this.