Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to hide certain elements within the URL Params #315

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

Chucky3920
Copy link
Contributor

Helps when using IFrame within other web applications

sidebar=false - Hides Sidebar.js
coordinates=false - Hides UICoordinates.js
link=false - Hides UILink.js
controls=false - Hides Leaflet controls

… using IFrame within other web applications

sidebar=false - Hides Sidebar.js
coordinates=false - Hides UICoordinates.js
link=false - Hides UILink.js
controls=false Hides Leaflet controls
Copy link
Owner

@jpenilla jpenilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the names to be prefixed with show_, also for the link UI use show_link_button

show_coordinates=false - Hides UICoordinates.js
show_link_button=false - Hides UILink.js
show_controls=false Hides Leaflet controls
@Chucky3920 Chucky3920 requested a review from jpenilla October 16, 2024 20:24
@jpenilla
Copy link
Owner

It looks like unset is not the correct default display for some of these elements:
image
I think we should just set display to none if the param is false, otherwise do nothing and leave the defaults.

@jpenilla jpenilla merged commit 9d44f94 into jpenilla:master Oct 17, 2024
1 check passed
@jpenilla
Copy link
Owner

Merged with some minor changes and included in 1.3.0 - I'd be interested in your feedback on #319. Sadly I didn't think about it until after pushing the release, but the versioning is for the plugin rather than the Web UI, so even if it could be considered a breaking change I would be fine changing this in 1.3.1 for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants