Use !Send types for wasm32 support. #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpfs
added a commit
to saveoursecrets/sdk
that referenced
this pull request
Jul 15, 2022
cargo check --target=wasm32-unknown-unknown --no-default-features --features client Requires two upstream PRs to land: seanmonstar/reqwest#1576 jpopesculian/reqwest-eventsource#10
|
Hi! Any news on this? I'm relying on this crate for a project and interested on using support for wasm |
tmpfs
added a commit
to saveoursecrets/sdk
that referenced
this pull request
Jan 28, 2023
cargo check --target=wasm32-unknown-unknown --no-default-features --features client Requires two upstream PRs to land: seanmonstar/reqwest#1576 jpopesculian/reqwest-eventsource#10
| @@ -15,7 +15,7 @@ categories = ["web-programming::http-client", "no-std", "parsing", "asynchronous | |||
|
|
|||
| [dependencies] | |||
| eventsource-stream = "0.2.3" | |||
| reqwest = { version = "0.11", default-features = false, features = ["stream"] } | |||
| reqwest = { version = "0.11", path = "../reqwest", default-features = false, features = ["stream"] } | |||
There was a problem hiding this comment.
Is the path value expected ?
cargo check fail (see below for the error message) when until I remove that field.
Updating git repository `https://github.com/tmpfs/reqwest-eventsource.git`
error: no matching package named `reqwest` found
location searched: https://github.com/tmpfs/reqwest-eventsource.git?rev=6ce0923ccc7cae4ce39a600b35425a62edc632b5#6ce0923c
required by package `reqwest-eventsource v0.4.0 (https://github.com/tmpfs/reqwest-eventsource.git?rev=6ce0923ccc7cae4ce39a600b35425a62edc632b5#6ce0923c)`
... which satisfies git dependency `reqwest-eventsource` of package `sse-web v0.1.0 (/home/[Redacted]/Documents/platform_sse/sse-web)`
|
Hi @FirelightFlagboy, I don't need this anymore so won't continue to work on this, however, I noticed that |
|
closed with #13 thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends upon landing wasm32 support for
bytes_stream()inreqwest; I have opened a PR that adds support here.If we can land that PR and this one then this library should work in wasm32 😁