fix: throw an error if the status code is a faulty one and stop the stream if a 204 is received #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #7.
A better fix would be to only allow 200, as stated by the spec, but this isn't possible without a BC break: it's not possible to create a new
reqwest::Error
for the other status codes.We have a similar problem with the Content-Type: it must be set by the server to
text/event-stream
, and we should throw an error if it's not the case, but there is currently no correspondingreqwest::Error
.A better solution (at the cost of a BC break), is to introduce our custom error type (using
thiserror
or a similar crate). I suggest merging this patch as a quick fix for the current version, and to start working on a better implem in a new major version.