-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unevaluatedProperties.json #743
base: main
Are you sure you want to change the base?
Conversation
json-schema-org#723 think removing the bar matches the test with the description, as foo itself is evaluated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to just add a test rather than change one. This test has purpose.
But then description need to be change for this {
"description": "when if is true and has no unevaluated properties",
"data": {
"foo": "then",
"bar": "bar"
},
"valid": false
} as bar is unevaluated , if we change the description it will become duplicate of other test |
If i am not wong currently this test is duplicate of this one {
"description": "when if is true and has unevaluated properties",
"data": {
"foo": "then",
"bar": "bar",
"baz": "baz"
},
"valid": false
}, |
I think @MeastroZI was right the first time. The original test should be modified because it's just a duplicate of another test. Changing the test makes it cover a unique case and what it was testing is already covered elsewhere. |
No worries. I was on mobile and hadn't checked other tests. Sorry for the confusion. |
#723
I think removing the bar matches the test with the description, as foo itself is evaluated.