This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rough docs for unevaluatedItems #205
add rough docs for unevaluatedItems #205
Changes from 2 commits
06849ec
1561111
fa9a9c5
7c808fa
05c48d6
b154f7b
6e434e0
9eb6e3d
ba78445
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we use "attach themselves to items" anywhere as a "technical" term, I'd probably try to use something closer to how I phrased it in the above comment (that
items
doesn't "see inside"oneOf
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing specifically unique about
unevaluatedItems
in this respect -- in JSON Schema (at least any modern version), booleans are valid schemas. I'm not saying it's not worth pointing out or showing an example, but I'd rework the language here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.