Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pausing (Updated) #65

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Allow pausing (Updated) #65

merged 5 commits into from
Aug 22, 2024

Conversation

merv1n34k
Copy link
Contributor

This fixes #47 and closes #48.

What is added:

  1. -r argument - if game save is exist and valid, the game resumes
  2. G command - saves sudoku during the game
  3. Game save file is stored in $XDG_STATE_HOME/nudoku/ if set, otherwise $HOME/.local/state/nudoku/ is used.
  4. After game resumes the game save file is deleted
  5. Game save file name is defined as state.save

src/main.c Outdated Show resolved Hide resolved
src/main.c Outdated Show resolved Hide resolved
src/main.c Outdated Show resolved Hide resolved
src/main.c Outdated Show resolved Hide resolved
@merv1n34k
Copy link
Contributor Author

Thanks for the review!

@merv1n34k merv1n34k requested a review from jubalh August 15, 2024 22:03
src/main.c Show resolved Hide resolved
src/main.c Outdated Show resolved Hide resolved
@merv1n34k
Copy link
Contributor Author

Improvements:

  1. Instead of program exit user will be notified he can't save/open file.
  2. Updated get_saved_file_path to handle malloc properly, free fallback_path on exit.

@merv1n34k merv1n34k requested a review from jubalh August 22, 2024 08:14
@merv1n34k
Copy link
Contributor Author

Also, think it would be better to update the documentation as well.

src/main.c Show resolved Hide resolved
Copy link
Owner

@jubalh jubalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@merv1n34k merv1n34k requested a review from jubalh August 22, 2024 09:03
@jubalh jubalh merged commit ee22aed into jubalh:master Aug 22, 2024
2 checks passed
@jubalh
Copy link
Owner

jubalh commented Aug 22, 2024

Thanks!

@jubalh
Copy link
Owner

jubalh commented Aug 22, 2024

Let me know if you plan to work on more things.
I think to create a new release with your changes in the next days.

@merv1n34k
Copy link
Contributor Author

Well, one more thing before the release is to update the potfiles :)
Would it be okay if I skip some translations?

@merv1n34k merv1n34k deleted the fix47 branch August 22, 2024 10:21
@jubalh
Copy link
Owner

jubalh commented Aug 22, 2024

Would it be okay if I skip some translations?

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pausing game
2 participants