Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: save to stream #71

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Feature: save to stream #71

merged 1 commit into from
Sep 10, 2024

Conversation

McModknower
Copy link
Contributor

Add a commandline option -o similar to -p and -i that outputs a string that can be used for loading the sudoku with the -s option.

Closes #70

Feel free to comment on changes i should do, as this is a version i put together in just an hour.

man/nudoku.6 Outdated Show resolved Hide resolved
src/main.c Outdated
@@ -109,6 +110,7 @@ static void print_usage(void)
printf(_("-h help:\t\tPrint this help\n"));
printf(_("-v version:\t\tPrint version\n"));
printf(_("-c nocolor:\t\tDo not use colors\n"));
printf(_("-o output:\t\tOutput to Stream (inverse of -s)\n"));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Output stream (inverse of -s)" (stream should be lowercase)

src/main.c Outdated Show resolved Hide resolved
src/main.c Outdated Show resolved Hide resolved
Copy link
Owner

@jubalh jubalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the first commit (about editorconfig).

@McModknower
Copy link
Contributor Author

Please drop the first commit (about editorconfig).

rebase (from the log, but a force push) or revert (still in log)?

@jubalh jubalh self-requested a review September 10, 2024 05:29
Copy link
Owner

@jubalh jubalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Now please use git rebase -i HEAD~3
And drop the first commit (about editorconfig)
And squash the last commit.

So that means just replace pick in the first like with a d and the pick in the third line with a s. Then do git push -f.

@jubalh jubalh merged commit e83e9cd into jubalh:master Sep 10, 2024
2 checks passed
@jubalh
Copy link
Owner

jubalh commented Sep 10, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: save to stream
2 participants