Update: Improve code formatting and remove redundant setState calls

judemont · Jun 22, 2024 · 2d60f85 · 2d60f85
1 parent 4b269b4
commit 2d60f85
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/android/app/build.gradle b/android/app/build.gradle
@@ -51,20 +51,28 @@ android {
         versionName flutterVersionName
     }
 
-    buildTypes {
+    signingConfigs {
         release {
-            // TODO: Add your own signing config for the release build.
-            // Signing with the debug keys for now, so `flutter run --release` works.
-            signingConfig signingConfigs.debug
+            storeFile file("release-key.jks")
+            storePassword "iu2t7LwN"
+            keyAlias "mykey"
+            keyPassword "iu2t7LwN"
         }
     }
 
+    buildTypes {
+        release {
+            signingConfig signingConfigs.release
+        }
+    }
+
     dependenciesInfo {
         // Disables dependency metadata when building APKs.
         includeInApk = false
         // Disables dependency metadata when building Android App Bundles.
         includeInBundle = false
     }
+
 }
 
 flutter {

diff --git a/lib/screens/home.dart b/lib/screens/home.dart
@@ -228,16 +228,16 @@ class _HomeState extends State<Home> {
     clearListings = true,
     orderDirection = "desc",
   }) async {
-    setState(() {
-      isLoading = true;
-      listingError = false;
-    });
+    isLoading = true;
+    listingError = false;
+
     var values = await getListings(
       order: order,
       limit: limit,
       offset: offset,
       orderDirection: orderDirection,
     );
+
     setState(() {
       isLoading = false;
       if (clearListings) {

diff --git a/lib/screens/settings.dart b/lib/screens/settings.dart
@@ -119,10 +119,8 @@ class _SettingsState extends State<Settings> {
                         String? search,
                         bool addAll = false,
                       }) {
-                        setState(() {
-                          loadingError = false;
-                          isLoading = true;
-                        });
+                        loadingError = false;
+                        isLoading = true;
 
                         getAvailableCurrencies(
                           offset: offset,