Fix warning log when creating a new cache dir (#5200)

Signed-off-by: Changxin Miao <[email protected]> Signed-off-by: jiefenghuang <[email protected]> Co-authored-by: jiefenghuang <[email protected]>
juicedata · Oct 8, 2024 · 7eb68cb · 7eb68cb
1 parent 31f65ed
commit 7eb68cb
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/pkg/chunk/disk_cache.go b/pkg/chunk/disk_cache.go
@@ -496,14 +496,12 @@ func (cache *cacheStore) createDir(dir string) {
 		mode := cache.mode | (readmode >> 2) | (readmode >> 1)
 		var st os.FileInfo
 		var err error
+		dir = filepath.Clean(dir) // `CacheManager` appends "/" to dir, remove it so that following `filepath.Dir` returns the parent dir
 		if st, err = os.Stat(dir); os.IsNotExist(err) {
 			if filepath.Dir(dir) != dir {
 				cache.createDir(filepath.Dir(dir))
 			}
-			if err = os.Mkdir(dir, mode); err != nil {
-				logger.Warnf("create cache dir %s: %s", dir, err)
-				return err
-			}
+			_ = os.Mkdir(dir, mode)
 			// umask may remove some permissions
 			return os.Chmod(dir, mode)
 		} else if strings.HasPrefix(dir, cache.dir) && err == nil && st.Mode().Perm() != mode.Perm() { // check permission only