Support limiting number of cache items #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyrabbit
force-pushed
the
limit-cache-items
branch
5 times, most recently
from
6a46d09 to
f656ccd
Compare
Signed-off-by: Changxin Miao <[email protected]>
polyrabbit
force-pushed
the
limit-cache-items
branch
from
f656ccd to
c211ca4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5489 +/- ##
==========================================
- Coverage 55.09% 55.01% -0.08%
==========================================
Files 166 165 -1
Lines 47787 47705 -82
==========================================
- Hits 26327 26247 -80
+ Misses 18613 18611 -2
Partials 2847 2847 ☔ View full report in Codecov by Sentry. |
davies
reviewed
Jan 2, 2025
pkg/chunk/cached_store.go
Outdated
| @@ -650,6 +651,10 @@ func (c *Config) parseHours() (start, end int, err error) { | |||
| return | |||
| } | |||
|
|
|||
| func (c *Config) CacheEnabled() bool { | |||
| return c.CacheSize > 0 && c.CacheItems > 0 | |||
There was a problem hiding this comment.
CacheItems could be 0 for unlimited, we can only check CacheSize
davies
reviewed
Jan 2, 2025
polyrabbit
force-pushed
the
limit-cache-items
branch
3 times, most recently
from
68827a1 to
a62e17a
Compare
Signed-off-by: Changxin Miao <[email protected]>
polyrabbit
force-pushed
the
limit-cache-items
branch
from
a62e17a to
76961e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #5478 - to avoid inode usage confilicts when multiple volumes are scheduled to the same host.