Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump: use total inodes to set the total number of the progress bar #5493

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Jan 2, 2025

close #5483

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 21.39%. Comparing base (beaa0d0) to head (036dbdb).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/meta/sql.go 0.00% 19 Missing ⚠️
pkg/meta/tkv.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5493       +/-   ##
===========================================
- Coverage   55.09%   21.39%   -33.71%     
===========================================
  Files         166       29      -137     
  Lines       47787    19040    -28747     
===========================================
- Hits        26327     4073    -22254     
+ Misses      18613    14483     -4130     
+ Partials     2847      484     -2363     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhijian-pro zhijian-pro marked this pull request as draft January 2, 2025 03:05
@zhijian-pro zhijian-pro changed the title dump/sql: use total inodes to set the total number of the progress bar dump: use total inodes to set the total number of the progress bar Jan 2, 2025
@zhijian-pro zhijian-pro marked this pull request as ready for review January 2, 2025 07:41
@zhijian-pro zhijian-pro marked this pull request as draft January 2, 2025 07:58
@zhijian-pro zhijian-pro marked this pull request as ready for review January 3, 2025 02:39
@jiefenghuang jiefenghuang merged commit d329bb0 into main Jan 6, 2025
38 checks passed
@jiefenghuang jiefenghuang deleted the sql-dump-total branch January 6, 2025 07:51
@zhoucheng361 zhoucheng361 added missed missed bug module/dump&load dump&load labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missed missed bug module/dump&load dump&load
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump command problems
3 participants