update to php8.4

juliangut · Dec 26, 2024 · 736ae43 · 736ae43
1 parent f581da1
commit 736ae43
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml
@@ -16,7 +16,7 @@ jobs:
 
       - uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.3
+          php-version: 8.4
           coverage: none
 
       - name: Composer install
@@ -56,7 +56,7 @@ jobs:
 
       - uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.3
+          php-version: 8.4
           coverage: none
 
       - name: Composer install

diff --git a/.github/workflows/docker-inspect.yml b/.github/workflows/docker-inspect.yml
@@ -17,7 +17,7 @@ jobs:
 
       - uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.3
+          php-version: 8.4
           coverage: none
 
       - name: Composer install
@@ -57,7 +57,7 @@ jobs:
 
       - uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.3
+          php-version: 8.4
           coverage: none
 
       - name: Composer install

diff --git a/composer.json b/composer.json
@@ -24,7 +24,7 @@
   "minimum-stability": "dev",
   "prefer-stable": true,
   "require": {
-    "php": "^8.3",
+    "php": "^8.4",
     "ext-json": "*",
     "symfony/console": "^7.2",
     "twig/twig": "^3.17"

diff --git a/src/Command/ExportCommand.php b/src/Command/ExportCommand.php
@@ -57,7 +57,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
         foreach ($this->versions as $variant => $variantConfig) {
             foreach ($variantConfig as $version => $config) {
                 $tags = array_map(
-                    static fn(string $tag): string => 'juliangut/phpdev:' . trim($tag),
+                    static fn(string $tag): string => 'juliangut/phpdev:' . mb_trim($tag),
                     $config['tags'],
                 );
 

diff --git a/src/Command/ScaffoldAllCommand.php b/src/Command/ScaffoldAllCommand.php
@@ -56,7 +56,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
 
         $directory = $input->getOption('directory');
         $this->assertStringType($directory);
-        $directory = rtrim($directory, \DIRECTORY_SEPARATOR);
+        $directory = mb_rtrim($directory, \DIRECTORY_SEPARATOR);
         $destinationDir = getcwd() . '/' . $directory;
         $this->removeDirectory($destinationDir);
         if (!mkdir($destinationDir, 0o755, true) && !is_dir($destinationDir)) {

diff --git a/src/Command/ScaffoldCommand.php b/src/Command/ScaffoldCommand.php
@@ -138,7 +138,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
 
         $directory = $input->getOption('directory');
         $this->assertStringType($directory);
-        $destinationDir = getcwd() . '/' . rtrim($directory, \DIRECTORY_SEPARATOR);
+        $destinationDir = getcwd() . '/' . mb_rtrim($directory, \DIRECTORY_SEPARATOR);
         $this->removeDirectory($destinationDir);
         if (!mkdir($destinationDir, 0o755, true) && !is_dir($destinationDir)) {
             $ioStyle->error(\sprintf('Not possible to create "%s" directory', $destinationDir));