feat: Add picklist mode sample to the example app #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 17, 2024 10:58
jsroest
changed the title
… Remove the optimisation, that's now not needed anymore.
…orners seems not correct, but that does not influence this use-case.
|
|
|
|
added 2 commits
December 2, 2024 11:39
# Conflicts: # example/lib/picklist/barcode_scanner_picklist.dart # example/lib/picklist/classes/barcode_at_center.dart
|
The latest version of the picklist sample uses the fact that the image size is now always available, also when returnImage is false. It still relies on two workarounds 'fixPortraitLandscape' and 'fixCorners'. picklist_sample.mov |
|
Hi all, sorry for my absence, but i've tested your code and it looks like the example runs fine on android and ios! I do think we also need to solve the issues mentioned in #1183, but since this code is only an example, and it also contains a workaround for now, i think it is save to merge this into our current release, and try to fix #1183 in a next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a picklist mode sample to the sample app.
This sample is not fully optimised, because of this issue:
MobileScannerState.size is not equal to BarcodeCapture.size on iOS