fix: start should reset error code

CHANGELOG.md

@@ -9,6 +9,7 @@ Bugs fixed:
 * [Apple] Fixed an issue which caused the scanWindow to always be present, even when reset to no value.
 * [Apple] Fixed an issue that caused the barcode size to report the wrong height.
 * [Apple] Fixed a bug that caused the corner points to not be returned in clockwise orientation.
+* Fixed a bug where the permission error code is not reset when the scanner is started correctly.
 
 Improvements:
 * Added a basic barcode overlay widget, for use with the camera preview.

lib/src/mobile_scanner_controller.dart

@@ -295,6 +295,8 @@ class MobileScannerController extends ValueNotifier<MobileScannerState> {
           // Provide the current torch state.
           // Updates are provided by the `torchStateStream`.
           torchState: viewAttributes.currentTorchMode,
+          // At this point the scanner started correctly, so reset any previous error.
+          resetError: true,
         );
       }
     } on MobileScannerException catch (error) {
@@ -348,9 +350,27 @@ class MobileScannerController extends ValueNotifier<MobileScannerState> {
       torchState: oldTorchState == TorchState.unavailable
           ? TorchState.unavailable
           : TorchState.off,
+      resetError: true,
     );
 
-    await MobileScannerPlatform.instance.stop();
+    try {
+      await MobileScannerPlatform.instance.stop();
+    } catch (error, stackTrace) {
+      if (_isDisposed) {
+        return;
+      }
+
+      // If the camera failed to stop, report the error.
+      value = value.copyWith(
+        error: MobileScannerException(
+          errorCode: MobileScannerErrorCode.genericError,
+          errorDetails: MobileScannerErrorDetails(
+            details: stackTrace.toString(),
+            message: error.toString(),
+          ),
+        ),
+      );
+    }
   }
 
   /// Switch between the front and back camera.

lib/src/objects/mobile_scanner_state.dart

@@ -72,6 +72,8 @@ class MobileScannerState {
   }
 
   /// Create a copy of this state with the given parameters.
+  ///
+  /// If [resetError] is `true`, the error will be reset to null.
   MobileScannerState copyWith({
     int? availableCameras,
     CameraFacing? cameraDirection,
@@ -81,11 +83,12 @@ class MobileScannerState {
     Size? size,
     TorchState? torchState,
     double? zoomScale,
+    bool resetError = false,
   }) {
     return MobileScannerState(
       availableCameras: availableCameras ?? this.availableCameras,
       cameraDirection: cameraDirection ?? this.cameraDirection,
-      error: error,
+      error: resetError ? null : error ?? this.error,
       isInitialized: isInitialized ?? this.isInitialized,
       isRunning: isRunning ?? this.isRunning,
       size: size ?? this.size,