Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rwbase.py: fix edge case #404

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update rwbase.py: fix edge case #404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7444b11
Update rwbase.py: fix edge case
NightMachinery Nov 18, 2024
1fac804
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions nbformat/v4/rwbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
# Distributed under the terms of the Modified BSD License.
from __future__ import annotations

from collections.abc import Mapping


def _is_json_mime(mime):
"""Is a key a JSON mime-type that should be left alone?"""
Expand Down Expand Up @@ -97,6 +99,10 @@ def strip_transient(nb):

This should be called in *both* read and write.
"""
# Handle malformed notebooks where metadata was incorrectly set as a non-dictionary type
if not isinstance(nb.metadata, Mapping):
nb.metadata = dict()

nb.metadata.pop("orig_nbformat", None)
nb.metadata.pop("orig_nbformat_minor", None)
nb.metadata.pop("signature", None)
Expand Down