Skip to content

Commit

Permalink
Merge pull request #1815 from yuvipanda/use-action
Browse files Browse the repository at this point in the history
Use setup-helm action to install helm
  • Loading branch information
manics authored Jan 22, 2024
2 parents 92176d7 + dca0445 commit c4ec9ad
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,13 @@ jobs:
- name: Set up Docker Buildx (for chartpress multi-arch builds)
uses: docker/setup-buildx-action@v3

- name: Install chart publishing dependencies (chartpress, helm)
- name: Setup helm
uses: azure/setup-helm@v3
with:
version: "v3.5.4"

- name: Install chart publishing dependencies (chartpress, etc)
run: |
. ./ci/common
setup_helm v3.5.4
pip install --no-cache-dir chartpress>=2.1 pyyaml build
- name: Build binderhub wheel
Expand Down
6 changes: 0 additions & 6 deletions ci/common
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
#!/bin/sh
# Use https://www.shellcheck.net/ to reduce mistakes if you make changes to this file.

setup_helm() {
helm_version="${1}"
echo "setup helm ${helm_version}"
curl -sf https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | DESIRED_VERSION="${helm_version}" bash
}

await_jupyterhub() {
kubectl rollout status --watch --timeout 300s deployment/proxy \
&& kubectl rollout status --watch --timeout 300s deployment/hub \
Expand Down

0 comments on commit c4ec9ad

Please sign in to comment.