Close launcher button styling and close launcher with delete key #655
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
Also, please update the PR description. It's currently a (near) duplicate of jupyterlab/jupyterlab#15347 |
e218736
changed the title
removed launcher caption and button padding
krassowski
added
enhancement
krassowski
dismissed
their stale review
Review comments addressed; not approving yet as waiting for CI but no longer blocking in case if someone else gets back to it before me.
|
@gabalafou I see that you mentioned this PR in jupyterlab/jupyterlab#15347. Once this is ready I am happy to merge and release but currently your review is blocking here:
|
| tab.contains(focusedElement) | ||
| ); | ||
| if (index >= 0) { | ||
| this.currentIndex = index; |
| { | ||
| className: 'lm-TabBar-tabLabel', | ||
| tabindex: '-1', | ||
| 'aria-hidden': 'true' |
There was a problem hiding this comment.
Why is this aria-hidden: true?
References
#15303 - Issue no. 3 - Arrow key navigation between launcher tabs not as expected
#15347 - Change close launcher div to button for screen reader accessibility
When screen reader is active, pressing caps lock + right arrow key lands on close launcher div but does not close on Enter.
Accessibility documentation states an optional keyboard interaction where, if deletion is allowed, pressing "Delete" closes the current tab element and its associated tab panel
Code changes
Changed styling of close launcher to original after div has been changed to button (in PR 15347)
Enabling focused tab to be closed using "Delete" on keyboard