-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.4.x] Support Pyodide 0.27 #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
add new accepted wheel pyodide_*_wasm32.whl
kept WASM_WHL constant to avoid needless breakage
xref to the issue about this in micropip
here: pyodide/micropip#158. Should I put together a PR to resolve this in micropip
first before this new ABI tag lands here (and subsequently, have it in a new micropip
0.8.1 release via a Pyodide 0.27.1 release)?
Either way, I think this PR looks good for Pyodide 0.27.0 and micropip
0.8.0 in specific, and the above can be taken into account with another [0.4.y] update after this one.
Actually, never mind, that was fixed with pyodide/micropip#159 which made it to the 0.7.2 release already, it is just that the issue was not closed (I'll mark it as closed now). All good, sorry for the confusion! |
Yeah, that's why I don't bother following It's... non-trivial to replace it from a I don't think we can do anything about the I am trying some more notebooks from jupyterlite's docs on RTD, and may do some more abusive checks with those wheels, but otherwise, this is likely ready for more review and testing. |
Thanks for the additional context! We are planning to unvendor recipes with Pyodide 0.28 (it is our near term plan). Would it be worthwhile to unvendor Yes, |
Yeah, jlpl works, but only through a rather ridiculous contraption of browser automation, and a custom web server/proxy. Until such a time as we can do an accurate
Yeah, no skin in the game there. We'll continue to minimize user-space breakage, and support upstream features as best we can here.
I wouldn't worry too much about us: that's why use all those types, have tests, and generally try to get our downstream releases out quickly, but only after an actual upstream release. There are too many moving upstream parts for us to do much else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@meeseeksdev please backport to main |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Looks like we still need a manual backport to In the meantime, starting a new |
* bump versions * accept some FS as any * rework piplite * also invert _query_packages ordering * update compatibility matrix
* bump versions * accept some FS as any * rework piplite * also invert _query_packages ordering * update compatibility matrix Co-authored-by: Nicholas Bollweg <[email protected]>
Cool, thanks for the release. Also merged the conda-forge PR, will see about getting the beta out a tick. |
References
micropip
0.8 #153 (with manual cherry-picks)0.4.x
instead ofmain
(justChanges
pyodide
in all the various placesmicropip
0.8 #153piplite.piplite._query_package
'sindex_urls
andfetch_kwargs
pyodide_*_wasm32.whl
WASM_WHL
constant to avoid needless breakagepiplite
CLI spec with support annotations