refactor: added browser-info to confirm call #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishBudhiraja
approved these changes
Dec 24, 2024
Sanskar2001
reviewed
Dec 25, 2024
Comment on lines
+305
to
+307
| device_model: option<string>, | ||
| os_type: option<string>, | ||
| os_version: option<string>, |
There was a problem hiding this comment.
can you make the type string instead, anyways from native side you are always collecting these and putting them in hyper params
Suggested change
| device_model: option<string>, | |
| os_type: option<string>, | |
| os_version: option<string>, | |
| device_model: string, | |
| os_type: string, | |
| os_version: string, |
There was a problem hiding this comment.
any way both serve the same purpose, right?
Comment on lines
+928
to
+930
| device_model: getOptionString(hyperParams, "device_model"), | ||
| os_type: getOptionString(hyperParams, "os_type"), | ||
| os_version: getOptionString(hyperParams, "os_version"), |
There was a problem hiding this comment.
Suggested change
| device_model: getOptionString(hyperParams, "device_model"), | |
| os_type: getOptionString(hyperParams, "os_type"), | |
| os_version: getOptionString(hyperParams, "os_version"), | |
| device_model: getString(hyperParams, "device_model", ""), | |
| os_type: getString(hyperParams, "os_type", ""), | |
| os_version: getString(hyperParams, "os_version", ""), |
There was a problem hiding this comment.
do we need these changes @sh-iv-am?
There was a problem hiding this comment.
I don't think so as browser_info is not required for all PMs and connectors.
aashu331998
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will browser/ device details to the confirm call