Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new analytics filters feature flag #2084

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Jan 17, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

new analytics currency filter display feature flag
new_analytics_filters this single flag will handle the filter dipaly for payment,refunds,smart retry tab, and when its set to false the filters wont be visible, and smart retry toggle is independent of this flag value

when its set to false
Screenshot 2025-01-17 at 5 48 51 PM

when its set to true
Screenshot 2025-01-17 at 5 49 11 PM
Screenshot 2025-01-17 at 5 49 17 PM
Screenshot 2025-01-17 at 5 49 27 PM

Motivation and Context

How did you test it?

this feature flag value will determine whether to show or hide currency filters for new analytics

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed analytics labels Jan 17, 2025
@sagarnaikjuspay sagarnaikjuspay self-assigned this Jan 17, 2025
@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner January 17, 2025 12:22
Copy link

Review changes with  SemanticDiff

@JeevaRamu0104 JeevaRamu0104 merged commit b60da23 into main Jan 20, 2025
5 of 6 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the new-analytics-filters-feature-flag branch January 20, 2025 05:25
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed analytics labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature flag for currency filters for new analytics [insights page]
2 participants