Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(user_roles): migrations for backfilling user_roles entity_id #6847

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix(user_roles): migrations for backfilling user_roles entity_id #6847

merged 3 commits into from
Dec 16, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 commented Dec 16, 2024 •
edited by ThisIsMani
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR ensures that the entity_id is backfilled in the user_roles table, preventing issues for V1 users when switching organizations and logging in.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Main pr #6837
Closes #6843

How did you test it?

Using local dashboard

  • Login to V1 account
  • invite the user to that same account
  • Try to switch organizations and merchant

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner December 16, 2024 10:03
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Dec 16, 2024
@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Dec 16, 2024
@ThisIsMani ThisIsMani linked an issue Dec 16, 2024 that may be closed by this pull request
fix(user_roles): migrations for backfilling user_roles entity_id #6843
Open
@Riddhiagrawal001 Riddhiagrawal001 changed the title fix(users): migrations for backfilling user_roles entity_id fix(users): migrations for backfilling user_roles entity_id Dec 16, 2024
@Riddhiagrawal001 Riddhiagrawal001 changed the title fix(users): migrations for backfilling user_roles entity_id fix(user_roles): migrations for backfilling user_roles entity_id Dec 16, 2024
@likhinbopanna likhinbopanna merged commit aae4667 into hotfix-2024.12.11.0 Dec 16, 2024
28 of 34 checks passed
@likhinbopanna likhinbopanna deleted the email-hotfix branch December 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisIsMani ThisIsMani ThisIsMani approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(user_roles): migrations for backfilling user_roles entity_id
4 participants
@Riddhiagrawal001 @SanchithHegde @ThisIsMani @likhinbopanna